XNA Creators Club Online
Page 1 of 1 (16 items)
Sort Posts: Previous Next

RPG Starter Kit Bug

Last post 05-30-2008 1:58 AM by John Campbell. 15 replies.
  • 05-20-2008 8:38 PM

    RPG Starter Kit Bug

    It seems that the RPG starter kit has a bug that will cause it to lock up after you attack in combat.  This happens in both windows and the xbox version.  Someone on the IRC chat mentioned something about a while loop with no escape condition.  I've not had time to look at the source yet.
  • 05-20-2008 9:58 PM In reply to

    Re: RPG Starter Kit Bug

    We cannot reproduce this bug; "attacking in combat" works correctly on both platforms.  Please provide more information about the exact conditions leading up to the crash.  This could include the save game itself, which is just XML data, and the circumstances of the crash (hang, unhandled exception, etc.).
    Matthew Picioccio
    XNA Developer Connection
  • 05-20-2008 10:12 PM In reply to

    Re: RPG Starter Kit Bug

    I pushed this onto my 360 and played it for quite a while without any issue.
  • 05-20-2008 10:49 PM In reply to

    Re: RPG Starter Kit Bug

    Let me see if I can't reproduce this now that I'm home and on a different xbox 360.  I'll also see what it does in windows.
  • 05-20-2008 11:04 PM In reply to

    Re: RPG Starter Kit Bug

    I can reproduce this on windows.  It seems the game will randomly get stuck in a loop after I attack.  I'll try to locate the exact issue and post more details.

     

    The loop it gets stuck in is on line 1924/1925 of CombatEngine.cs and looks like:
    while (players[newHighlightedPlayer].IsDeadOrDying || 
                                players[newHighlightedPlayer].IsTurnTaken);

     

  • 05-20-2008 11:15 PM In reply to

    Re: RPG Starter Kit Bug

    Okay, I can make the game freeze every time if I move the left thumb stick around as my character is returning back to their position after making an attack.  If I do not move the thumb stick during that animation, the game does not freeze.  Currently I've only tested this for the first tutorial fight.
  • 05-21-2008 12:25 AM In reply to

    Re: RPG Starter Kit Bug

    IEqualShane:
    Okay, I can make the game freeze every time if I move the left thumb stick around as my character is returning back to their position after making an attack.  If I do not move the thumb stick during that animation, the game does not freeze.  Currently I've only tested this for the first tutorial fight.

     

    Okay, I've confirmed that issue.  Waggle the stick when you're the only party member and you're walking back into position after attacking, and the game hangs.

     

    I'll add it to our internal bug list.  I'm not sure when we would provide a new version - it may be several weeks at a minimum.  We'll also work up some language for a "known issues" section on the starter kit page.

     

    Thanks!


    Matthew Picioccio
    XNA Developer Connection
  • 05-21-2008 12:47 AM In reply to

    Re: RPG Starter Kit Bug

    Yeah, I don't actually need the starter kit,  I just wanted to make sure the bug was known.  I didn't want to post this to connect if it was only me who was having the issue.
  • 05-21-2008 1:06 AM In reply to

    Re: RPG Starter Kit Bug


    IEqualShane:
    Yeah, I don't actually need the starter kit,  I just wanted to make sure the bug was known.  I didn't want to post this to connect if it was only me who was having the issue.

     

    The starter kit is definitely playable; just don't waggle the thumbstick in the time between when the last party member attacks and the start of the monsters' turn.  ;)

     

    The bug is that the CombatEngine.HandleInput function is allowing the player to attempt to change the active player when the players' turn is already over.  There's already a property for this; the fix is to add an additional condition to the "if" statement at the beginning of the function (Combat\CombatEngine.cs, approximately line 1761).  

    Change the line from:

                if (!IsPlayersTurn || (highlightedCombatant == null))

    to

                if (!IsPlayersTurn || IsPlayersTurnComplete ||
                    (highlightedCombatant == null))

     

    The same message as above - we'll add this to known issues list, and we don't have any information at this time about new versions.
     

    Thanks again for the report!

    Matthew Picioccio
    XNA Developer Connection
  • 05-21-2008 10:59 AM In reply to

    Re: RPG Starter Kit Bug

    Hi,

    I'm having the same problem in the RPG Starter Kit, where it freezes sometimes in the middle of a battle.
    I'm not sure if it is only an input issue, because when the game freezes I get some FileNotFoundExceptions in the Debug window.

    Bruno Evangelista,
    Homepage | XNAnimation
    Ziggyware Article: Playing Nice Animations with XNA
    For what will it profit a man if he gains the whole world and forfeits his soul? Or what will a man give in exchange for his soul?, Matthew 16:26
  • 05-21-2008 4:50 PM In reply to

    Re: RPG Starter Kit Bug

    I haven't tried that bug, but I did find another:

    Complete both of the first quests. Equip the shield and sword. Attempt to drop the dagger. The game locks up. It's happening in the BreakTextIntoLines function when it's trying to break up the text "Are you sure you want to drop the Dagger" (which is missing the question mark BTW, unless it's being inserted afterwards). Haven't figured out why yet as I haven't stepped through it. I'll look at it in a bit.

     

    Update: Looks like changing this line:

    while (nextIndex < maximumCharactersPerLine)

    to this:

    while (nextIndex < maximumCharactersPerLine && nextIndex > 0)

    and this line:

    text.IndexOf(' ', 0);

    to this:

    int nextIndex = text.IndexOf(' ', 0);

     

    fixes the bug.



    Jim Perry - Microsoft XNA MVP
    Here's what I'm up to.
    If people spent a minute searching the forums before posting I'd be out of a job.
  • 05-21-2008 5:36 PM In reply to

    Re: RPG Starter Kit Bug

    I've been meaning to test out the starter kit more for bugs, but my video card actually fried shortly after my last post.  My coworkers/friends hate it when I test their code because I somehow always find bugs (which you'd think would be doing them a service).  Maybe it's because I do things like randomly press buttons and move left thumbsticks around when I'm waiting for animations to complete ;-)

    Now I just need to wait for Dell to show up with my new video card tomorrow.  Thank god for overnight service.


  • 05-22-2008 7:21 PM In reply to